-
Notifications
You must be signed in to change notification settings - Fork 484
[Builtins] Add an inlinable version of 'geq' #7323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Builtins] Add an inlinable version of 'geq' #7323
Conversation
/benchmark lists |
2 similar comments
/benchmark lists |
/benchmark lists |
Click here to check the status of your benchmark. |
/benchmark nofib |
2 similar comments
/benchmark nofib |
/benchmark nofib |
/benchmark validation |
1 similar comment
/benchmark validation |
|
Comparing benchmark results of 'lists' on '354c1eaf71' (base) and 'da0c69d6eb' (PR) Results table
|
Click here to check the status of your benchmark. |
Comparing benchmark results of 'lists' on '354c1eaf71' (base) and 'da0c69d6eb' (PR) Results table
|
Click here to check the status of your benchmark. |
Comparing benchmark results of 'lists' on '354c1eaf71' (base) and 'da0c69d6eb' (PR) Results table
|
Click here to check the status of your benchmark. |
Comparing benchmark results of 'nofib' on '354c1eaf71' (base) and 'da0c69d6eb' (PR) Results table
|
Click here to check the status of your benchmark. |
Comparing benchmark results of 'nofib' on '354c1eaf71' (base) and 'da0c69d6eb' (PR) Results table
|
Click here to check the status of your benchmark. |
Comparing benchmark results of 'nofib' on '354c1eaf71' (base) and 'da0c69d6eb' (PR) Results table
|
Click here to check the status of your benchmark. |
Comparing benchmark results of 'validation' on '354c1eaf71' (base) and 'da0c69d6eb' (PR) Results table
|
Click here to check the status of your benchmark. |
/benchmark validation |
Comparing benchmark results of 'nofib' on '531f1b8d80' (base) and 'd9866f6b36' (PR) Results table
|
Click here to check the status of your benchmark. |
Comparing benchmark results of 'lists' on '531f1b8d80' (base) and 'd9866f6b36' (PR) Results table
|
Click here to check the status of your benchmark. |
Comparing benchmark results of 'lists' on '531f1b8d80' (base) and 'd9866f6b36' (PR) Results table
|
Click here to check the status of your benchmark. |
Comparing benchmark results of 'lists' on '531f1b8d80' (base) and 'd9866f6b36' (PR) Results table
|
Click here to check the status of your benchmark. |
Comparing benchmark results of 'validation' on '531f1b8d80' (base) and 'd9866f6b36' (PR) Results table
|
Click here to check the status of your benchmark. |
Comparing benchmark results of 'validation' on '531f1b8d80' (base) and 'd9866f6b36' (PR) Results table
|
Click here to check the status of your benchmark. |
Comparing benchmark results of 'validation' on '531f1b8d80' (base) and 'd9866f6b36' (PR) Results table
|
Click here to check the status of your benchmark. |
Comparing benchmark results of 'data' on '531f1b8d80' (base) and 'd9866f6b36' (PR) Results table
|
Click here to check the status of your benchmark. |
Comparing benchmark results of 'data' on '531f1b8d80' (base) and 'd9866f6b36' (PR) Results table
|
Click here to check the status of your benchmark. |
Comparing benchmark results of 'data' on '531f1b8d80' (base) and 'd9866f6b36' (PR) Results table
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good. Cool trick
…effectfully/builtins/add-an-inlinable-version-of-geq
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll need to study this a bit more later to understand it better, but given the evident speedup, feel free to merge.
At long last I think I've finally discovered a way to create an inlinable version of
geq
.Previous attempts: #4462, #4463, #5061, #6352.